This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Complete the names-to-numbers conversion in nd_syscalls.stp.


On 05/17/2009 11:09 AM, Przemyslaw Pawelczyk wrote:
> Replace in-scope variables references with *_arg functions. Use 'kprobe'
> family of probes instead of 'kernel' family for dwarfless probing. Also
> fix a few typos and unify formatting.

Thanks a lot -- this is good work!  I went ahead and committed this to
the repo, but I would ask for a couple more things before we declare
this "complete".  First, as Ananth pointed out, we will eventually need
to deal with the SYSCALL_WRAPPERS for some archs.  Second is that we now
need to start nd_syscalls2.stp to get the full syscall set.  Are you up
to tackling that as well?

Long term, we'll probably want to rename the dwarf syscall tapset to
something like dw_syscall, and then provide aliases like:
  probe syscall.foo = dw_syscall.foo !, nd_syscall.foo {}


Josh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]