This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Complete the names-to-numbers conversion in nd_syscalls.stp.
- From: Josh Stone <jistone at redhat dot com>
- To: Przemyslaw Pawelczyk <przemyslaw at pawelczyk dot it>
- Cc: systemtap at sourceware dot org
- Date: Mon, 18 May 2009 16:55:41 -0700
- Subject: Re: [PATCH] Complete the names-to-numbers conversion in nd_syscalls.stp.
- References: <1242587305.670381.9610@debian>
On 05/17/2009 11:09 AM, Przemyslaw Pawelczyk wrote:
> Replace in-scope variables references with *_arg functions. Use 'kprobe'
> family of probes instead of 'kernel' family for dwarfless probing. Also
> fix a few typos and unify formatting.
Thanks a lot -- this is good work! I went ahead and committed this to
the repo, but I would ask for a couple more things before we declare
this "complete". First, as Ananth pointed out, we will eventually need
to deal with the SYSCALL_WRAPPERS for some archs. Second is that we now
need to start nd_syscalls2.stp to get the full syscall set. Are you up
to tackling that as well?
Long term, we'll probably want to rename the dwarf syscall tapset to
something like dw_syscall, and then provide aliases like:
probe syscall.foo = dw_syscall.foo !, nd_syscall.foo {}
Josh