This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: An enhancement of -p option checking so as to accept only one digital number


Hi Sunzen,

On Mon, 2009-05-18 at 08:05 +0800, Sunzen Wang wrote:
> Sorry for my late notice.   Actually the same type of issue also
> exists for some other options(-s, -x, and partly -S).
> It seems better to use a nearly unified solution to enhance their checking.
> The first problem is:  is it necessary to do such kind of seemingly
> trivial 'enhancement' ?

I think it is a fine enhancement. It will probably help someone when
starting out with stap and getting the option arguments wrong. If you
have time to do it generically please do. But if you just fix it option
at a time that seems fine too. Assuming it isn't really lots of
duplicate code, which it doesn't seem to be, just one line per option
processed.

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]