This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Member session missing in signal_struct for 2.6.30-rc5


Wenji Huang wrote:
Hi,

The commit in kernel

signals: check_kill_permission: check session under tasklist_lock
author    Oleg Nesterov <oleg@tv-sign.ru>
    Wed, 30 Apr 2008 07:53:01 +0000 (00:53 -0700)
committer    Linus Torvalds <torvalds@linux-foundation.org>
    Wed, 30 Apr 2008 15:29:37 +0000 (08:29 -0700)
commit    2e2ba22ea4fd4bb85f0fa37c521066db6775cbef

Sorry, paste the wrong text. See

author	Oleg Nesterov <oleg@redhat.com>
	Thu, 2 Apr 2009 23:58:39 +0000 (16:58 -0700)
committer	Linus Torvalds <torvalds@linux-foundation.org>
	Fri, 3 Apr 2009 02:05:02 +0000 (19:05 -0700)
commit	1b0f7ffd0ea27cd3a0b9ca04e3df9522048c32a3

pids: kill signal_struct-> __pgrp/__session and friends

We are wasting 2 words in signal_struct without any reason to implement
task_pgrp_nr() and task_session_nr().

task_session_nr() has no callers since
2e2ba22ea4fd4bb85f0fa37c521066db6775cbef, we can remove it.

task_pgrp_nr() is still (I believe wrongly) used in fs/autofsX and
fs/coda.

This patch reimplements task_pgrp_nr() via task_pgrp_nr_ns(), and kills
__pgrp/__session and the related helpers.

The change in drivers/char/tty_io.c is cosmetic, but hopefully makes sense anyway.

removed member session from signal_struct. This results in
compilation error for sid() on latest kernel.

I haven't found the replacement for the member or alike function.
Guess need to make it available under %kernel_v or other solution
if someone had.

Regards,
Wenji


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]