This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH -rc] [BUGFIX] x86: fix kernel_trap_sp()



On Tue, 12 May 2009, Robin Holt wrote:
> >   */
> > -static inline unsigned long kernel_trap_sp(struct pt_regs *regs)
> > +static inline unsigned long kernel_stack_pointer(struct pt_regs *regs)
> 
> Why not have it return an unsigned long *?

I considered it, but since part of the point of the patch was to make it 
look like the mirror of "user_stack_pointer()", returning "unsigned long" 
looked more appropriate.

But I have no really strong opinions. I wouldn't object to making it 
return "unsigned long *" either.

		Linus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]