This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v5 5/7] x86: fix kernel_trap_sp()
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: Christoph Hellwig <hch at infradead dot org>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, kvm <kvm at vger dot kernel dot org>, Harvey Harrison <harvey dot harrison at gmail dot com>, Thomas Gleixner <tglx at linutronix dot de>, Jan Blunck <jblunck at suse dot de>
- Date: Mon, 11 May 2009 09:48:52 -0400
- Subject: Re: [PATCH -tip v5 5/7] x86: fix kernel_trap_sp()
- References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509004904.5505.59034.stgit@localhost.localdomain> <20090511092841.GB23875@infradead.org>
Christoph Hellwig wrote:
> On Fri, May 08, 2009 at 08:49:04PM -0400, Masami Hiramatsu wrote:
>> Use ®s->sp instead of regs for getting the top of stack in kernel mode.
>> (on x86-64, regs->sp always points the top of stack)
>
> Shouldn't this patch be sent for inclusion ASAP instead of sitting in
> this series?
Yes, and it's just for asking a comment from oprofile developers,
because this change will change its behavior a bit.
Anyway, I'll post it separately against upstream.
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com