This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2


Hi Ananth,

On Wed, 2009-04-29 at 17:51 +0530, Ananth N Mavinakayanahalli wrote:
> On Wed, Apr 29, 2009 at 02:08:23PM +0200, Mark Wielaard wrote:
> > The rest does seem to PASS as before, but I am somewhat concerned
> that
> > the tests were originally designed to test function (.call/return)
> > probes, which are different from syscall (.return) probes. So are we
> > really still testing the correct things?
> 
> Maybe the choice of functions weren't correct in the first place? Why
> don't we change this to say, vfs_read instead of sys_read?

That sounds like a good plan to me.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]