This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Systemtap snap:b6371390 test on kernel 2.6.30-rc3-git2


On Tue, 2009-04-28 at 11:30 +0530, Pavan Naregundi wrote:
> > > FAIL: compiling sdt.c ""
> > > FAIL: compiling sdt.c additional_flags=-std=gnu89
> > > FAIL: compiling sdt.c additional_flags=-ansi
> > > FAIL: compiling sdt.c additional_flags=-pedantic
> > > FAIL: compiling sdt.c additional_flags=-ansi additional_flags=-pedantic
> > > FAIL: compiling sdt.c additional_flags=-O2
> > > FAIL: compiling sdt.c additional_flags="-O3"
> > > FAIL: static_uprobes compiling C -g
> 
> Running /home/pavan/systemtap/src/testsuite/systemtap.base/sdt.exp ...
> Executing on host: gcc
> /home/pavan/systemtap/src/testsuite/systemtap.base/sdt.c  -g
> -I/home/pavan/systemtap/src/testsuite/../includes/sys -Wall -Wextra -Werror
> -lm   -o sdt.c.exe.0    (timeout = 300)
> /tmp/ccastHp6.s: Assembler messages:^M
> /tmp/ccastHp6.s:57: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:116: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:179: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:246: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:317: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:392: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:471: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:554: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:640: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:729: Error: junk at end of line: `0'^M
> compiler exited with status 1
> output is:
> /tmp/ccastHp6.s: Assembler messages:^M
> /tmp/ccastHp6.s:57: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:116: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:179: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:246: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:317: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:392: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:471: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:554: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:640: Error: junk at end of line: `0'^M
> /tmp/ccastHp6.s:729: Error: junk at end of line: `0'^M
> 
> FAIL: compiling sdt.c ""
> UNTESTED: sdt ""
> 
> >
> > That probably means the sdt.h header doesn't compile on ppc.
> > Could you see if testsuite/systemtap.log gives more hints about what is
> > wrong? What gcc version are you using?
> 
> gcc version 4.3.2 20081007 (Red Hat 4.3.2-6) (GCC)

Thanks, I think the new "nop 0" in sdt.h is wrong on ppc64
I don't have a ppc64 around, but maybe this will work (assuming these
tests did work before):

diff --git a/includes/sys/sdt.h b/includes/sys/sdt.h
index f89b736..8e87942 100644
--- a/includes/sys/sdt.h
+++ b/includes/sys/sdt.h
@@ -58,7 +58,7 @@
 #define STAP_UNINLINE_LABEL(label) \
   __extension__ static volatile long labelval  __attribute__ ((unused))
= (long) &&label
 
-#if defined(__x86_64__) || defined(__i386__)
+#if defined(__x86_64__) || defined(__i386__) || defined(__ppc64__)
 #define STAP_NOP "\tnop "
 #else
 #define STAP_NOP "\tnop 0 "

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]