This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug uprobes/10078] uretprobes: longjmp fix broke funcs returning structs


------- Additional Comments From jkenisto at us dot ibm dot com  2009-04-21 00:06 -------
This doesn't affect x86_64, powerpc, or s390 -- if the ABI docs are correct.

After discussing this with FChE, I've checked in Fix #2 for x86_32 -- commit
436e5bf.  This includes a regression test, bz10078.exp.

I believe that this kludge causes a problem only in the following scenario:
- Function A calls setjmp and then calls B; and
- B or one of its callees calls longjmp; and
- A's stack frame contains no local variables or saved registers (including
%ebp), and B's stack frame contains no args.  I.e., there's nothing between the
return addresses in the two stack frames.
In such a scenario, we wouldn't detect that B has been bypassed by the longjmp.

I'm marking this fixed.  Reopen if it turns out we need a more sophisticated fix.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=10078

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]