This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/1] Add new TCP and IP functions


Josh

Thanks for the good review

Josh Stone wrote:
>> +/* returns TCP URG flag for a given sk_buff structure */
>> +function __tcp_skb_urg:long (skb:long){
>> +	urg = ntohs(@cast(__get_skb_tcphdr(skb), "tcphdr")->urg) & 32
>> +	return urg >> 5
>> +}
> 
> Such bit-manipulation shouldn't be needed, but it looks like our
> generated dereference code is not masking out bitfields correctly.  I'll
> file a bugzilla on this.

That is right. So, should I wait until it's fixed, or just let it as it is ?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]