This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.9.5-105-g117bcbe


Hi David,

On Wed, 2009-04-08 at 18:15 +0000, dsmith@sourceware.org wrote:

> commit 117bcbe45ff448c0913007d31cfa2be78caeb4ba
> Author: David Smith <dsmith@redhat.com>
> Date:   Wed Apr 8 13:14:24 2009 -0500
> 
>     Added '#ifdef STP_NEED_VMA_TRACKER' around code that needs it.
>     2009-04-08  David Smith  <dsmith@redhat.com>
>     
>             * runtime/sym.c: Added '#ifdef STP_NEED_VMA_TRACKER' around code
>             that needs it.

This breaks code needing the vma tracker, like the usymbols.exp test,
because sym.c is included way before the tapset has a chance to define
STP_NEED_VMA_TRACKER. I set things up as it was before 782040: "PR 9940.
Rearchitected task_finder.c a bit." With task_finder.c only defining a
dummy stap_task_finder_target if ! defined (CONFIG_UTRACE), and
otherwise the whole implementation. It can then again be unconditionally
imported through runtime.h.

commit df7a5a2ccf193473c347308d7fa711a9e626e7b0
Author: Mark Wielaard <mjw@redhat.com>
Date:   Wed Apr 8 23:35:21 2009 +0200

    Make sure code using the vma tracker compiles again.
    
    * runtime/runtime.h: Include task_finder.c.
    * runtime/sym.c: Always define task_finder callbacks for usage
      in tapsets.
    * runtime/task_finder.c: Define dummy stap_task_finder_target when
      ! defined(CONFIG_UTRACE).
    * tapsets.cxx: Never include task_finder.c directly.

Let me know if that breaks something for you.

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]