This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: On ia64 #include "task_finder.c" need some function from regs-ia64.c


Mark Wielaard wrote:
> Hi Will,
> 
> On Thu, 2009-04-02 at 17:26 -0400, William Cohen wrote:
>> When compiling recent checkout of systemtap on ia64 the inclusion of
>> "task_finder.c" ended up needed some code in reg-ia64.h. Did some permutations
>> of includes to make sure that regs.c and regs-ia64.c are included before
>> task_finder.c. That patch has verified to work on ia64 and x86_64. Below is the
>> error message before the added patch.
> 
> Your patch looks cleaner than what I quickly committed. Thanks for
> cleaning it up.
> 
> Cheers,
> 
> Mark
> 

Mark,

Thanks for explaining the reasons for position of the task_finder.c include.
That helped avoid going down some dead ends.

Seemed like a good idea to avoid forward declarations. Why have something
declared in two places when can do it in one place?

-Will


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]