This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH - v2] Fix for insn probe: Call arch_has_*_step() prior to calling utrace_control
- From: Josh Stone <jistone at redhat dot com>
- To: Maynard Johnson <maynardj at us dot ibm dot com>
- Cc: systemtap at sourceware dot org, "Frank Ch. Eigler" <fche at redhat dot com>
- Date: Wed, 01 Apr 2009 17:12:44 -0700
- Subject: Re: [PATCH - v2] Fix for insn probe: Call arch_has_*_step() prior to calling utrace_control
- References: <49D3CDF1.6000601@us.ibm.com>
Maynard Johnson wrote:
> The attached patch is version 2 for the problem I reported earlier today.
>
> Frank, is this more what you had in mind? With this patch, there's no need for the user to look at the system log. Error messages are sent to stderr:
>
> ERROR: insn probe init: arch does not support block step mode
> ERROR: probe process("/test").function("doit1@/test.c:22").return registration error (rc -1)
>
> -Maynard
I committed both this and your testcase.
Josh