This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Adding kerneldoc and fixing bare pointers
Breno Leitao <leitao@linux.vnet.ibm.com> writes:
> This patch create a kerneldoc comments for the main functions used by
> these tapsets.
> Also some kread() are used instead of bare pointers
> [...]
> tapset/dccp_ccid3_hc_tx_sock.stp | 4 ++--
> tapset/inet_sock.stp | 21 +++++++++++++++++++++
> tapset/iphdr.stp | 17 ++++++++++++++++-
> tapset/sk.stp | 10 +++++++++-
> tapset/tcp_states.stp | 16 ++++++++++++++++
> tapset/tcphdr.stp | 20 ++++++++++++++++++++
Do you think there is a need for so many different files?
> static inline void *ccid_priv(const struct ccid *ccid)
> -{
> - return (void *)ccid->ccid_priv;
> +%{
> + return (void *)kread(&(ccid))->ccid_priv;
> }
> %}
Many of these functions could probably be replaced by plain
script-level functions that use @cast().
Some test suite additions are necessary to confirm that all of these
functions (and as many probes as possible) actually build. See the
buildok/tcp* files; some useful demo systemtap.examples/FOO.stp would
also be nice.
Thank you for all the added documentation.
- FChE