This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC][PATCH 0/5] NFS: trace points added to mounting path
- From: "K.Prasad" <prasad at linux dot vnet dot ibm dot com>
- To: Jeff Moyer <jmoyer at redhat dot com>, Steve Dickson <SteveD at redhat dot com>
- Cc: Greg Banks <gnb at melbourne dot sgi dot com>, Linux NFSv4 mailing list <nfsv4 at linux-nfs dot org>, Linux NFS Mailing list <linux-nfs at vger dot kernel dot org>, SystemTAP <systemtap at sources dot redhat dot com>, Christoph Hellwig <hch at infradead dot org>, Maneesh Soni <maneesh at in dot ibm dot com>
- Date: Wed, 21 Jan 2009 15:43:29 +0530
- Subject: Re: [RFC][PATCH 0/5] NFS: trace points added to mounting path
- References: <49711BDF.3010605@melbourne.sgi.com> <x49ab9ntlpp.fsf@segfault.boston.devel.redhat.com>
- Reply-to: prasad at linux dot vnet dot ibm dot com
On Mon, Jan 19, 2009 at 09:27:30AM -0500, Jeff Moyer wrote:
> Greg Banks <gnb@melbourne.sgi.com> writes:
>
> > Steve Dickson wrote:
> >> So the ultimate goal would be to replace all the dprintks with trace points
> >> but still be able to enable them through the rpcdebug command
> > I have a patch which changes the definition of the dprintk() macro (but
> > *not* dprintk() callsites) to allow enabling and disabling individual
> > dprintk() statements through a /proc/ interface. Would you be
> > interested in that?
>
> That sounds like duplicated work. How does it differ from Jason Baron's
> dynamic printk patches (which I believe are now upstream)?
>
> Cheers,
> Jeff
Introducing/converting one of the accepted methods of static
instrumentation - like tracepoints would help more users (whether
in-kernel or otherwise) harness them.
Steve,
Would it help convert the systemtap script (nfs_mount.stp) in
Patch - 5 into a kernel module (perhaps in samples/ directory) to bring
an in-kernel user of these tracepoints?
Thanks,
K.Prasad