This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 5/7] kprobes: Remove called_from argument
- From: Masami Hiramatsu <mhiramat at redhat dot com>
- To: ananth at in dot ibm dot com
- Cc: Andrew Morton <akpm at linux-foundation dot org>, Jim Keniston <jkenisto at us dot ibm dot com>, David Miller <davem at davemloft dot net>, Rusty Russell <rusty at rustcorp dot com dot au>, LKML <linux-kernel at vger dot kernel dot org>, systemtap-ml <systemtap at sources dot redhat dot com>
- Date: Wed, 12 Nov 2008 10:36:33 -0500
- Subject: Re: [PATCH 5/7] kprobes: Remove called_from argument
- References: <4919F1A9.5070601@redhat.com> <20081112065238.GB3081@in.ibm.com>
Hi Ananth,
Ananth N Mavinakayanahalli wrote:
>
> You also need the following to get this to compile, don't you?
Oops, Indeed.
Thank you very much!
Where I've lost this parts...?
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Index: linux-2.6.28-rc4/kernel/kprobes.c
> ===================================================================
> --- linux-2.6.28-rc4.orig/kernel/kprobes.c 2008-11-12 11:13:30.000000000 +0530
> +++ linux-2.6.28-rc4/kernel/kprobes.c 2008-11-12 12:18:44.000000000 +0530
> @@ -666,8 +666,6 @@
> */
> probed_mod = __module_text_address((unsigned long) p->addr);
> if (probed_mod) {
> - struct module *calling_mod;
> - calling_mod = __module_text_address(called_from);
> /*
> * We must hold a refcount of the probed module while updating
> * its code to prohibit unexpected unloading.
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com