This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)

Hi -

On Fri, Sep 05, 2008 at 12:04:43PM -0400, Masami Hiramatsu wrote:
> [...]
> I think adding those fields increases the overhead of cleanup/initialize
> and memory usage. So I decided to introduce new structure for that.
> Could you tell me what the advantage of those separated fields is?

It's not a big difference, just that we tend to keep such data in the
context.  I mostly don't like the new struct being passed by void-*
and then suffering unprotected dereference in the embedded-c
functions.

(Extra memory consumption is negligible - one more word per CPU.
Initialization time/space could be further reduced if
per-probe-point-type data were gathered into unions.)

- FChE
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]