This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)

Frank Ch. Eigler wrote:
> Hi -
> 
> On Fri, Sep 05, 2008 at 11:32:24AM -0400, Masami Hiramatsu wrote:
>> Here is a patch which add $name variable access from marker probe.
>> I added _stp_mark_context structure which contains .name and .format
>> strings for passing both of them to marker handler. [...]
> 
> That seems unnecessary.  You could have added the name/format as
> separate fields, and have the embedded-C functions use
> CONTEXT->marker_name / marker_format.  (Those fields then better be
> cleared to zero for other types of probes, and the embedded-C code
> better check for that.)

I think adding those fields increases the overhead of cleanup/initialize
and memory usage. So I decided to introduce new structure for that.
Could you tell me what the advantage of those separated fields is?

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]