This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH]PR 4886: validate debuginfo based on build-id
- From: David Smith <dsmith at redhat dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: Wenji Huang <wenji dot huang at oracle dot com>, systemtap at sources dot redhat dot com
- Date: Wed, 16 Jul 2008 12:34:30 -0500
- Subject: Re: [PATCH]PR 4886: validate debuginfo based on build-id
- References: <487C30BE.3070706@oracle.com> <y0mmykik3cy.fsf@ton.toronto.redhat.com>
Frank Ch. Eigler wrote:
> Wenji Huang <wenji.huang@oracle.com> writes:
>
>> The patch is to provide sanity check of debuginfo(PR 4886) based on
>> build-id [...]
>
> Thanks for giving this a try. Rather than put it into the
> systemtap_session struct, how about emitting it into the _stp_module[]
> data via translate.cxx? (runtime/sym.h would need a few more fields.)
> That should also immediately apply to user-space modules.
At some point we'll need to add the buildid to the hash we use to lookup
cached .c/.ko files. This way if we compile a script against user
program "foo", then if "foo" gets recompiled, the hash will get
automatically changed, which means we won't reused the cached module.
We'll need the buildid of the kernel, any modules used, and any
user-space programs/libraries used. It would be great if we grab the
buildid once for everything needed instead of twice.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)