Re: Adding provide to systemtap.spec for systemtap-testsuite rpm

[Masami Hiramatsu <mhiramat at redhat dot com>]

Hi Will,

William Cohen wrote:
> I haven't seen that effect without bundled_elfutils stap was not required.
> However, I see that there are some lines that fiddle with the __find_provides.

Here is the rpmbuild logs of systemtap-testsuite

$ rpmbuild -bb --with bundled_elfutils systemtap.spec
---
Processing files: systemtap-testsuite-0.6.1-1.fc7
Finding  Provides: /bin/sh -c "/usr/lib/rpm/find-provides | sed '/libelf/d;/libdw/d;/libebl/d'"
Finding  Requires: /bin/sh -c "/usr/lib/rpm/find-requires | sed '/libelf/d;/libdw/d;/libebl/d'"
Requires(rpmlib): rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1
Requires: systemtap dejagnu /bin/sh /usr/bin/env /usr/bin/perl /usr/bin/tclsh stap perl(Getopt::Std)
---                                                                           ^^^^

With bundled_elfutils option, systemtap.spec disables the internal
dependency generator and uses their special filters.
It missed eliminating 'stap' from requires.

$ rpmbuild -bb --without bundled_elfutils systemtap.spec
---
Processing files: systemtap-testsuite-0.6.1-1.fc7
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /bin/sh /usr/bin/env /usr/bin/perl /usr/bin/tclsh dejagnu perl(Getopt::Std) systemtap
---
Without bundled_elfutils, the testsuite package does not require stap.

> The rpmbuild process scans through executable files to find out which 
> interpreters are used by various scripts. There are a number of scripts in the 
> tests that begin with:
> 
> #! stap
> 
> The scanning picks out the interpreter, "stap" and makes it a dependency for 
> systemtap-testsuite.

I guess the rpmbuild solves the absolute path of 'stap' and finds it in
the systemtap package.

> So does it make sense to install systemtap-testsuite without systemtap? If 
> systemtap-testsuite should be installed with systemtap, it seems like the 
> explicit provides would be reasonable.

I agree.
I just think that the testsuite package would better have same "requires"
list regardless of whether the bundled_elfutils option is specified or not.

Thank you,

> 
> -Will

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com