This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.

From: "Stone, Joshua I" <joshua dot i dot stone at intel dot com>
To: "Cai Fei" <caifei at cn dot fujitsu dot com>
Cc: <systemtap at sourceware dot org>
Date: Mon, 15 Oct 2007 10:41:37 -0700
Subject: RE: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.
References: <470EC2B0.4020803@cn.fujitsu.com> <16D5B9AB904B0B46B22A27002EE3A8C801061336@scsmsx415.amr.corp.intel.com> <4712AD0D.1070705@cn.fujitsu.com>

Cai Fei wrote:
> Thanks for your suggestion. I have changed it to kernel_string_n.
> Also, I have tested it on RHEL5(IA64).

I meant an automated test, so that it gets tested and verified on all
platforms.  The addition of a length parameter creates several corner
cases that need to work safely. (length <= 0, length > MAXSTRINGLEN,
etc.)

Josh

References:
- [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.
  - From: Cai Fei
- RE: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.
  - From: Stone, Joshua I
- Re: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.
  - From: Cai Fei

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]