This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/2] Trace code and documentation
- From: Sam Ravnborg <sam at ravnborg dot org>
- To: David Wilder <dwilder at us dot ibm dot com>
- Cc: linux-kernel at vger dot kernel dot org, SystemTAP <systemtap at sources dot redhat dot com>, akpm at linux-foundation dot org
- Date: Fri, 14 Sep 2007 19:50:27 +0200
- Subject: Re: [PATCH 1/2] Trace code and documentation
- References: <46E9CB14.7060000@us.ibm.com>
Hi David.
A random comment to the code.
Several of the struct file_operations are not declared static as
they should be.
Btw. it looks good from a coding style point-of-view.
About the name what about ktrace??
Sam