This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Additions to TCP tapset

From: Mike Mason <mmlnx at us dot ibm dot com>
To: "Frank Ch. Eigler" <fche at redhat dot com>
Cc: Eugene Teo <eteo at redhat dot com>, systemtap at sourceware dot org
Date: Tue, 10 Jul 2007 13:56:56 -0700
Subject: Re: Additions to TCP tapset
References: <4693AE47.4080205@redhat.com> <y0my7hof51f.fsf@ton.toronto.redhat.com>

Frank Ch. Eigler wrote:

Eugene Teo <eteo@redhat.com> writes:

[...]  Kindly review please. I will commit the changes if there are
no objection.


Please try to build this in terms of ordinary script code.  It can
just export two arrays for name<->number mappings (or perhaps two
functions to provide read-only access to the arrays).  It is not
obvious to me that there is any advantage to the embedded-C code.

See the socket.stp tapset for examples of Frank's suggestion.

Mike

- FChE

Follow-Ups:
- Re: Additions to TCP tapset
  - From: Jim Keniston

References:
- Additions to TCP tapset
  - From: Eugene Teo
- Re: Additions to TCP tapset
  - From: Frank Ch. Eigler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]