This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug kprobes/4384] Problem in making kprobe modules portable across all the archtecture.


------- Additional Comments From ananth at in dot ibm dot com  2007-04-17 15:43 -------
Srinivasa,
The patch looks fine.... you'll need to fix the codingstyle:

 	}								\
+	else {								\
       ^^^^^
+		char dot_name[KSYM_NAME_LEN+1];				\
+		dot_name[0] = '.';					\
+		strncat(dot_name, name, KSYM_NAME_LEN);			\
+		addr = (kprobe_opcode_t *)kallsyms_lookup_name(dot_name); \
+	}								\
 }

Please include a short description and post it to powerpc-dev list for
inclusion. Feel free to put my signed-off once you've successfully tested the patch.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4384

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]