This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] kprobes patch


Jun Koi wrote:

Hi Keshavanmurthy,

On 10/28/06, Keshavamurthy@bambi.jf.intel.com
<Keshavamurthy@bambi.jf.intel.com> wrote:

On Sat, Oct 28, 2006 at 03:58:18AM +0900, Jun Koi wrote:
> Hello,
>
> I am not sure if this is a right place to send patch for kprobes, but
> here it is.  This patch moves the reset command of kprobe instance
> into the loop. (against 2.6.18)

Hi jun,
Yes, you have sent it to the right place. thanks.
BTW, is is helpful to know what problem did you encounter due to which
you had come up with this patch. Or did you catch this bug by just code review?



I had no problem at al. You are right, the patch is a result of reviewing the code.

Can you think of a test case that exercises this part of the code so we can make sure this change doesn't adversely affect existing functionality.



Best, Jun




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]