This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Linux Kernel Markers 0.20 for 2.6.17
- From: Mathieu Desnoyers <compudj at krystal dot dyndns dot org>
- To: Jeremy Fitzhardinge <jeremy at goop dot org>
- Cc: Atsushi Nemoto <anemo at mba dot ocn dot ne dot jp>, mbligh at google dot com, fche at redhat dot com, masami dot hiramatsu dot pt at hitachi dot com, prasanna at in dot ibm dot com, akpm at osdl dot org, mingo at elte dot hu, lethal at linux-sh dot org, linux-kernel at vger dot kernel dot org, jes at sgi dot com, zanussi at us dot ibm dot com, richardj_moore at uk dot ibm dot com, michel dot dagenais at polymtl dot ca, hch at infradead dot org, gregkh at suse dot de, tglx at linutronix dot de, wcohen at redhat dot com, ltt-dev at shafik dot org, systemtap at sources dot redhat dot com, alan at lxorguk dot ukuu dot org dot uk, karim at opersys dot com, pavel at suse dot cz, joe at perches dot com, rdunlap at xenotime dot net, jrs at us dot ibm dot com
- Date: Tue, 17 Oct 2006 15:19:24 -0400
- Subject: Re: [PATCH] Linux Kernel Markers 0.20 for 2.6.17
- References: <20060930180443.GB25761@Krystal> <20061018.005122.07644172.anemo@mba.ocn.ne.jp> <453522B1.7040103@goop.org>
* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> Atsushi Nemoto wrote:
> >When I compiled this with gcc 4.1.1 (mips), ".markers" section was
> >empty.
> >
> >I suppose "unused" attribute is not suitable for modern gcc. Maybe
> >__attribute_used__ should be used?
> >
>
> It should be, but it still won't work. There's a gcc bug which ignores
> the attribute for local-scope static variables:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29299
>
>
> J
>
I guess the correct way to handle it will be to put a "used" attribute in the
asm-generic/marker.h code, remove the unnecessary "unused" attribute in
asm-powerpc/marker.h and tell people to upgrade their gcc when it is broken.
The other way around would be to make the macro "use" the structure somewhere
without any impact.
Mathieu
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68