This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linux Kernel Markers 0.20 for 2.6.17


* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> Atsushi Nemoto wrote:
> >When I compiled this with gcc 4.1.1 (mips), ".markers" section was
> >empty.
> >
> >I suppose "unused" attribute is not suitable for modern gcc.  Maybe
> >__attribute_used__ should be used?
> >  
> 
> It should be, but it still won't work.  There's a gcc bug which ignores 
> the attribute for local-scope static variables:  
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29299
> 
> 
>    J
> 

I guess the correct way to handle it will be to put a "used" attribute in the
asm-generic/marker.h code, remove the unnecessary "unused" attribute in
asm-powerpc/marker.h and tell people to upgrade their gcc when it is broken.
The other way around would be to make the macro "use" the structure somewhere
without any impact.

Mathieu

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]