This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Linux Kernel Markers 0.11 for 2.6.17
- From: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- To: Jeremy Fitzhardinge <jeremy at goop dot org>
- Cc: Martin Bligh <mbligh at google dot com>, "Frank Ch. Eigler" <fche at redhat dot com>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, prasanna at in dot ibm dot com, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at elte dot hu>, Paul Mundt <lethal at linux-sh dot org>, linux-kernel <linux-kernel at vger dot kernel dot org>, Jes Sorensen <jes at sgi dot com>, Tom Zanussi <zanussi at us dot ibm dot com>, Richard J Moore <richardj_moore at uk dot ibm dot com>, Michel Dagenais <michel dot dagenais at polymtl dot ca>, Christoph Hellwig <hch at infradead dot org>, Greg Kroah-Hartman <gregkh at suse dot de>, Thomas Gleixner <tglx at linutronix dot de>, William Cohen <wcohen at redhat dot com>, ltt-dev at shafik dot org, systemtap at sources dot redhat dot com, Alan Cox <alan at lxorguk dot ukuu dot org dot uk>, Karim Yaghmour <karim at opersys dot com>, Pavel Machek <pavel at suse dot cz>, Joe Perches <joe at perches dot com>, "Randy.Dunlap" <rdunlap at xenotime dot net>, "Jose R. Santos" <jrs at us dot ibm dot com>
- Date: Mon, 25 Sep 2006 19:13:43 -0400
- Subject: Re: [PATCH] Linux Kernel Markers 0.11 for 2.6.17
- References: <20060925151028.GA14695@Krystal> <45181CE9.1080204@goop.org>
* Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> If you're going to put different types in the .markers section
> (presumably per-architecture, rather than different types for within one
> architecture) you should probably also define a structure in the same
> place, if nothing
>
For now, I only expect two kinds of structures :
One for the architectures which implements the MARK_JUMP optimisation and one
where they don't. Does it make sense to assume that each architecture will offer
the possibility to write a 1 byte offset calculated from the difference between
two addresses ? If not, then, it can be useful to think of a per archtecture
structure, but module.c shall be modified accordingly too. So for now, I would
stay with only one definition in linux/marker.h and if we see the need for it,
we can put the structures in asm-*/marker.h and adapt module.c per architecture
accordingly (probably by using a macro).
Mathieu
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68