This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Linux Kernel Markers 0.2 for Linux 2.6.17
- From: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: linux-kernel at vger dot kernel dot org, Christoph Hellwig <hch at infradead dot org>, Andrew Morton <akpm at osdl dot org>, Ingo Molnar <mingo at redhat dot com>, Greg Kroah-Hartman <gregkh at suse dot de>, Thomas Gleixner <tglx at linutronix dot de>, Douglas Niehaus <niehaus at eecs dot ku dot edu>, Tom Zanussi <zanussi at us dot ibm dot com>, Paul Mundt <lethal at linux-sh dot org>, Jes Sorensen <jes at sgi dot com>, Richard J Moore <richardj_moore at uk dot ibm dot com>, William Cohen <wcohen at redhat dot com>, "Martin J. Bligh" <mbligh at mbligh dot org>, Michel Dagenais <michel dot dagenais at polymtl dot ca>, systemtap at sources dot redhat dot com, ltt-dev at shafik dot org
- Date: Tue, 19 Sep 2006 15:36:24 -0400
- Subject: Re: [PATCH] Linux Kernel Markers 0.2 for Linux 2.6.17
- References: <20060919183447.GA16095@Krystal> <y0m4pv3ek49.fsf@ton.toronto.redhat.com>
* Frank Ch. Eigler (fche@redhat.com) wrote:
> If you don't allow yourself to presume on-the-fly function
> recompilation, then these markers would need to be made run-time
> rather than compile-time configurable. That is, not like this:
>
> > +/* Menu configured markers */
> > +#ifndef CONFIG_MARK
> > +#define MARK MARK_INACTIVE
> > +#elif defined(CONFIG_MARK_PRINT)
> > +#define MARK MARK_PRINT
> > +#elif defined(CONFIG_MARK_FPROBE)
> > +#define MARK MARK_FPROBE
> > +#elif defined(CONFIG_MARK_KPROBE)
> > +#define MARK MARK_KPROBE
> > +#elif defined(CONFIG_MARK_JPROBE)
> > +#define MARK MARK_JPROBE
> > +#endif
By making them run-time configurable, I don't see any whay not to bloat the
kernel. How can be embed calls to printk+function+kprobe+djprobe without
having some kind of performance impact ?
Do you have any suggestion for this ? (or maybe am I missing your point ?)
Mathieu
OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68