This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: kprobe fault handling


On Fri, 2006-02-10 at 16:45 -0500, Frank Ch. Eigler wrote:
> hunt wrote:
> 
> > [...]
> > function copy_more:long(addr:long)
> > %{
> >       THIS->__retvalue = _stp_copy_from_user (buf, 
> > 	(char __user *)(long)THIS->addr, 2048);
> > %}
> > [...]
> 
> As mentioned several times, this runtime routine "_stp_copy_from_user"
> is not safe, and should be rewritten or removed.

Yes, you always say this. Please tell us why that is so.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]