This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
RE: stp_exit change
- From: "Mao, Bibo" <bibo dot mao at intel dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>, "Martin Hunt" <hunt at redhat dot com>
- Cc: <systemtap at sources dot redhat dot com>
- Date: Mon, 16 Jan 2006 12:49:21 +0800
- Subject: RE: stp_exit change
I do not know whether we can delete atomic_set (&session_state, STAP_SESSION_STOPPING) sentence from runtime/io.c and add this sentence into file tapset/logging.stp like this:
function exit () %{
atomic_set (&session_state, STAP_SESSION_STOPPING);
_stp_exit ();
%}
Regards
Bibo,mao
>-----Original Message-----
>From: systemtap-owner@sourceware.org [mailto:systemtap-owner@sourceware.org]
>On Behalf Of Frank Ch. Eigler
>Sent: 2006年1月11日 6:19
>To: Martin Hunt
>Cc: systemtap@sources.redhat.com
>Subject: stp_exit change
>
>Hi -
>
>Can you please justify your change to runtime/io.c and
>tapset/logging.stp? Moving that line of code to stp_exit may be
>problematic because this function is invoked from more places than the
>exit() script function. In particular, this change interferes with
>STAP_SESSION_ERROR state handling.
>
>- FChE