This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
- From: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>
- To: Keith Owens <kaos at sgi dot com>
- Cc: "Randy.Dunlap" <rdunlap at xenotime dot net>, Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>, Paulo Marques <pmarques at grupopie dot com>, Linux Kernel <linux-kernel at vger dot kernel dot org>, akpm at osdl dot org, tony dot luck at intel dot com, Systemtap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at us dot ibm dot com>
- Date: Tue, 10 Jan 2006 16:39:57 -0800
- Subject: Re: [patch 1/2] [BUG]kallsyms_lookup_name should return the text addres
- References: <Pine.LNX.4.58.0601101606380.12724@shark.he.net> <20396.1136939008@ocs3.ocs.com.au>
- Reply-to: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>
On Wed, Jan 11, 2006 at 11:23:28AM +1100, Keith Owens wrote:
> "Randy.Dunlap" (on Tue, 10 Jan 2006 16:07:55 -0800 (PST)) wrote:
> >On Wed, 11 Jan 2006, Keith Owens wrote:
> >> Changing the thread slightly, kallsyms_lookup_name() has never coped
> >> with duplicate local symbols and it cannot do so without changing its
> >> API, and all its callers. For debugging purposes, it would be nicer if
> >> the kernel did not have any duplicate symbols. Perhaps some kernel
> >> janitor would like to take that task on.
> >
> >Jesper Juhl was doing some -Wshadow patches. Would that detect
> >duplicate symbols?
>
> No, the duplicate symbols are (a) static and (b) in separate source
> files. Run this against a System.map.
>
> awk '{print $NF}' System.map | egrep -v '^__ks|^__func' | sort | uniq -dc | LANG=C sort -k2
Humm..This duplication of symbols in the kernel will be a
problem for systemtap scripts, as we might end up putting probes
in the unwanted places :-(
I agree with you Keith, from the debugging purposes, it
would make sense not to have any duplicate symbols.
Thanks,
Anil