This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Review patches of user space kprobe
- From: Prasanna S Panchamukhi <prasanna at in dot ibm dot com>
- To: "Zhang, Yanmin" <yanmin dot zhang at intel dot com>
- Cc: systemtap at sources dot redhat dot com, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>, "Mao, Bibo" <bibo dot mao at intel dot com>
- Date: Fri, 6 Jan 2006 14:41:46 +0530
- Subject: Re: Review patches of user space kprobe
- References: <8126E4F969BA254AB43EA03C59F44E840464C390@pdsmsx404>
- Reply-to: prasanna at in dot ibm dot com
> >>readpage() routine reads one page at a time. we map the page one time and walk the
> >>probes list for this inode, insert all the probes within this page and then unmap it.
> Yes, I did see codes inserting all the probes on the page, but below codes:
> + if (kprobe_page_mapped) {
> + unmap_uprobe_page(up);
> + unlock_page(up->page);
> + }
>
> are only executed after the loop of hlist_for_each_entry. Is it correct?
>
that's correct. The page is mapped only once for the first match in the loop,
then all the probes are inserted into that page in the hlist_for_each loop and
then the page is unmapped only once after the end of the loop.
Thanks
Prasanna
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Email: prasanna@in.ibm.com
Ph: 91-80-25044636