This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: new systemtap snapshot available


"Mao, Bibo" <bibo.mao@intel.com> writes:

> [...]
> 	/tmp/stapsOq5Wi/stap_19359.c: In function `function_accumulate':
> 	/tmp/stapsOq5Wi/stap_19359.c:382: warning: cast from pointer to integer =
> [...]
> So I modify translate.cxx,as follows: [...]
> And it will compile and run ok in my IA32, EM64T and IA64 box.

Thank you for your patch, now committed.  I'm also adding the following
blurb to the HACKING guidelines:

   As far as practicable, changes should be accompanied by test cases
-  to prevent future regressions.
+  to prevent future regressions.  Tests should be run on at least
+  x86, and ideally also on some 64-bit platform.

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]