This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [Patch 2/5][Djprobe]Djprobe Coexist with Kprobes
- From: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- To: ananth at in dot ibm dot com
- Cc: systemtap at sources dot redhat dot com, Satoshi Oshima <soshima at redhat dot com>, Hideo Aoki <haoki at redhat dot com>, sugita at sdl dot hitachi dot co dot jp
- Date: Mon, 03 Oct 2005 09:36:07 +0900
- Subject: Re: [Patch 2/5][Djprobe]Djprobe Coexist with Kprobes
- References: <433BE533.9080501@sdl.hitachi.co.jp> <20050929143149.GA3682@in.ibm.com>
Hi,
Ananth N Mavinakayanahalli wrote:
> On Thu, Sep 29, 2005 at 09:59:31PM +0900, Masami Hiramatsu wrote:
>
> Few comments on first glance...
Thank you!
>>+ spin_lock(&djprobe_lock);
>
>
> Please use _irqsave/_irqrestore versions at all places.
OK, I will use it.
>>+ /* make a new instance */
>>+ djpi = kmalloc(sizeof(struct djprobe_instance),GFP_KERNEL);
>
>
> You are under a spinlock... this kmalloc may sleep.
Oh, it's a my mistake. I will change to GFP_ATOMIC.
>
> Follow CodingStyle please! There are a few other places in the existing
> kprobes code that also need a CodingStyle cleanup, but that is for a
> later patch.
OK, I will check my codes by using ./scripts/Lindent, and post patches again.
Thanks,
Best regards,
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp