This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64
- From: Prasanna S Panchamukhi <prasanna at in dot ibm dot com>
- To: Andi Kleen <ak at suse dot de>
- Cc: "Zhang, Yanmin" <yanmin dot zhang at intel dot com>, linux-kernel at vger dot kernel dot org, discuss at x86-64 dot org, systemtap at sources dot redhat dot com, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>
- Date: Thu, 29 Sep 2005 19:43:41 +0530
- Subject: Re: [discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64
- Reply-to: prasanna at in dot ibm dot com
>On Thu, Sep 29, 2005 at 08:43:44AM +0800, Zhang, Yanmin wrote:
>> <<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
>> when reading the source codes. Basically, the bug could break
>> kprobe_insn_pages under multi-thread environment. PPC arch also has the
>> problem.
>Can you describe what the problem actually is?
Andi,
The up()/down() orders are incorrect in arch/x86_64/kprobes.c file while
trying to get/remove a kprobes instruction slot in arch_prepare_kprobe()
and arch_remove_kprobe() routines. Zhang's patch corrects this.
Thanks
Prasanna
--
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<prasanna@in.ibm.com>