This is the mail archive of the systemtap-cvs@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.6-319-gc12bdea


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "systemtap: system-wide probe/trace tool".

The branch, master has been updated
       via  c12bdeab8e5515848ba0d2af21c8c6e5c072c42a (commit)
      from  eddbc9e4689f32acef46bd4f7ffb207577701d0f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c12bdeab8e5515848ba0d2af21c8c6e5c072c42a
Author: Josh Stone <jistone@redhat.com>
Date:   Mon Oct 17 15:18:06 2011 -0700

    PR13283: Use a temporary string for comparisons
    
    The reported issue was trying to directly compare the results of two
    different kernel_string() calls, but they were always computed equal
    even though they were known to be different.  Inspection of pass-3
    showed that both calls led to an expr-stmt ending in ...->__retvalue.
    This is just a pointer though, and it happens here that both calls will
    point to the same string buffer, so strncmp rightly calls them equal.
    
    To fix this, we must introduce temporary storage for the intermediate
    strings.  Now we won't lose either value, and they can be properly
    compared for equality.
    
    * translate.cxx (c_tmpcounter::visit_comparison): Declare temporary
      storage for the left operand if it's not a literal.
      (c_unparser::visit_comparison): Use the left temporary.
    * testsuite/systemtap.string/strcmp.*: Test string comparisons.

-----------------------------------------------------------------------

Summary of changes:
 testsuite/systemtap.string/strcmp.exp |   36 +++++++++++++++++++++++++
 testsuite/systemtap.string/strcmp.stp |   47 +++++++++++++++++++++++++++++++++
 translate.cxx                         |   36 +++++++++++++++++++++----
 3 files changed, 113 insertions(+), 6 deletions(-)
 create mode 100644 testsuite/systemtap.string/strcmp.exp
 create mode 100644 testsuite/systemtap.string/strcmp.stp


hooks/post-receive
--
systemtap: system-wide probe/trace tool


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]