This is the mail archive of the
sid@sources.redhat.com
mailing list for the SID project.
Re: [patch] Add Logging Support for SID Components
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: Dave Brolley <brolley at redhat dot com>
- Cc: sid at sources dot redhat dot com
- Date: Sun, 1 Jun 2003 10:32:40 -0400
- Subject: Re: [patch] Add Logging Support for SID Components
- References: <3ED7CCCB.4070004@redhat.com>
Hi -
> The attached patch adds logging support for sid components in 3 stages:
> [...]
Looks fine - good use of virtual inheritance. A few minor things
I might have done differently:
- make a new component type for named file I/O, instead of
changing sid-io-stdio; after all, stdio is bidirectional,
meant to be interactive
- think of some other way to call stdout than "*"
- make logging output buffering dependent on an attribute (set as the last
gasp of configuration) instead of pin-connectedness
- having a C++ flavour API (instead of printf()) for the logging function
- FChE