Re: [Aarch64] Fix _lseek prototype

[Christophe Lyon <christophe dot lyon at linaro dot org>]

On Tue, 2 Oct 2018 at 08:38, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>
> On Tue, 2 Oct 2018 at 00:18, Eric Blake <eblake@redhat.com> wrote:
> >
> > On 10/1/18 4:35 PM, Christophe Lyon wrote:
> > > Hi,
> > >
> > > While building newlib for Aarch64, I noticed a warning in _lseek. This
> > > small patch fixes the prototype.
> > >
> >
> > > +++ b/libgloss/aarch64/syscalls.c
> > > @@ -449,6 +449,7 @@ _swilseek (int fd, int ptr, int dir)
> > >       return -1;
> > >   }
> > >
> > > +int
> > >   _lseek (int fd, int ptr, int dir)
> >
> > Why int and not off_t?
> >
> Because that's how the prototype is defined at the beginning of the same file.
>
> Maybe time to revisit this?
>

Here is an updated version using "off_t" instead of "int".
OK?

> > --
> > Eric Blake, Principal Software Engineer
> > Red Hat, Inc.           +1-919-301-3266
> > Virtualization:  qemu.org | libvirt.org

Attachment: newlib-4.txt
Description: Text document