This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add timegm POSIX call [updated]


On 2018-08-22 15:02, Freddie Chopin wrote:
> On Wed, 2018-08-22 at 12:12 -0700, Andrew Russell via newlib wrote:
>> -static const int DAYS_IN_MONTH[12] =
>> +static const int_least16_t DAYS_IN_MONTH[12] =
>>  {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};
> 
> Shouldn't the type here be actually int_least8_t and int_least16_t used
> here ->

or uint_least{8,16}_t?

>> @@ -58,11 +61,21 @@ static const int DAYS_IN_MONTH[12] =
>>  static const int _DAYS_BEFORE_MONTH[12] =
>>  {0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};

and initialization use {U}INT{8,16}_C(value) macros?

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]