This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH v2] RISC-V: Do not use _init/_fini
- From: Kito Cheng <kito dot cheng at gmail dot com>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: Sebastian Huber <sebastian dot huber at embedded-brains dot de>, Newlib <newlib at sourceware dot org>
- Date: Wed, 1 Aug 2018 16:04:26 +0800
- Subject: Re: [PATCH v2] RISC-V: Do not use _init/_fini
- References: <20180730082844.14461-1-sebastian.huber@embedded-brains.de> <CAFyWVaagFgEx2B2BUy9p4T=k758p3YhNFmejvu4x6kqx6uxKWA@mail.gmail.com>
RISC-V part is LGTM.
On Wed, Aug 1, 2018 at 12:42 AM Jim Wilson <jimw@sifive.com> wrote:
> On Mon, Jul 30, 2018 at 1:28 AM, Sebastian Huber
> <sebastian.huber@embedded-brains.de> wrote:
> > Introduce new host configuration variable "have_init_fini" which is set
> > to "yes" by default. Override it for RISC-V to "no".
>
> I think this patch is much better than the previous one. Keeps the
> config stuff in one place. It looks good to me, but I'm not a newlib
> maintainer.
>
> Jim
>