This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: newlib Digest of: get.16090
- From: Thomas Preudhomme <thomas dot preudhomme at linaro dot org>
- To: newlib at sourceware dot org, Corinna Vinschen <vinschen at redhat dot com>
- Date: Fri, 13 Jul 2018 15:50:30 +0100
- Subject: Re: newlib Digest of: get.16090
- References: <1531492934.123366.ezmlm@sourceware.org>
> From: Corinna Vinschen <vinschen@redhat.com>
> To: newlib@sourceware.org, Bin Cheng <bin.cheng@arm.com>
> Cc: Kumar Gala <kumar.gala@linaro.org>
> Bcc:
> Date: Fri, 13 Jul 2018 13:37:43 +0200
> Subject: Re: [PATCH] Print sign of NaN values to nano-vfprintf.
> On Jul 12 13:13, Kumar Gala wrote:
> > Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
> > ---
> > newlib/libc/stdio/nano-vfprintf_float.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/newlib/libc/stdio/nano-vfprintf_float.c b/newlib/libc/stdio/nano-vfprintf_float.c
> > index 98893e97b..071a09edc 100644
> > --- a/newlib/libc/stdio/nano-vfprintf_float.c
> > +++ b/newlib/libc/stdio/nano-vfprintf_float.c
> > @@ -213,6 +213,8 @@ _printf_float (struct _reent *data,
> > }
> > if (isnan (_fpvalue))
> > {
> > + if (_fpvalue < 0)
> > + pdata->l_buf[0] = '-';
> > if (code <= 'G') /* 'A', 'E', 'F', or 'G'. */
> > cp = "NAN";
> > else
> > --
> > 2.14.4
>
> Any comment from the nano-printf guys?
LGTM.
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen
> Cygwin Maintainer
> Red Hat
Best regards,
Thomas