This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: Use _LDBL_EQ_DBL in nexttowardf.c
- From: Jon Roelofs <jroelofs at gmail dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: jjohnstn at redhat dot com, jroelofs at jroelofs dot com, newlib at sourceware dot org
- Date: Wed, 09 May 2018 03:03:48 +0000
- Subject: Re: Use _LDBL_EQ_DBL in nexttowardf.c
- References: <37dc8c3b-3b39-00b8-0f6a-f3125b4196c7@mentor.com>
LGTM
Jon
On Mon, May 7, 2018 at 3:39 AM Tom de Vries <Tom_deVries@mentor.com> wrote:
> Hi,
>
> quoting from here ( https://sourceware.org/ml/newlib/2014/msg00688.html ):
> ...
> > Drop the FORCE_EVAL macro, and wrap nexttowardf in _LDBL_EQ_DBL as
> per > Craig's suggestion.
> ...
>
> Actually, the patch that Jon submitted there is the same as before, and
> is missing those changes.
>
> The commit does contain those changes, except that it uses the
> non-existing macro _LDBL_EQ_DOUBLE instead of _LDBL_EQ_DBL.
>
> This patch fixes that.
>
> OK?
>
> [ Found this by running into a link error "unresolved symbol
> nexttowardf" for gcc testcase gcc/testsuite/gcc.dg/nextafter-2.c using
> the standalone nvptx toolchain. ]
>
> Thanks,
> - Tom
>