This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] implicit Unicode data tables generation


Am 09.03.2018 um 08:46 schrieb Thomas Wolff:
Am 08.03.2018 um 23:09 schrieb Thomas Wolff:
Am 08.03.2018 um 09:07 schrieb Corinna Vinschen:
On Mar  8 00:27, Thomas Wolff wrote:
This patch adds rules to generate Unicode data tables for
libc/string/wcwidth, libc/ctype/tow* and libc/ctype/isw* implicitly,
however, the build process is not yet covered.
The rules define how the necessary data tables are built,
but additional dependencies are missing to get the rules actually invoked,
like:
(string/Makefile.am)
wcwidth.c:    $(srcdir)/ambiguous.t $(srcdir)/combining.t $(srcdir)/wide.t
(ctype/Makefile.am)
categories.c:   $(srcdir)/categories.t
towctrans_l.c:  $(srcdir)/caseconv.t
I tried some variations (like $(srcdir)/wcwidth.c:..., lib_a-wcwidth.o:...,
and even an additional dummy wcwidth.h) but it did not work;
Look at ctype/Makefile.am, last line:

$(lpfx)ctype_.$(oext): ctype_.c ctype_iso.h ctype_cp.h

This should work for this case here, too.
Thanks, the following rules actually trigger the dependencies:
(string)
$(lpfx)wcwidth.$(oext): wcwidth.c ambiguous.t combining.t wide.t
(ctype)
$(lpfx)categories.$(oext): categories.c categories.t
$(lpfx)towctrans_l.$(oext): towctrans_l.c caseconv.t

but they cause obscure compilation errors:
...
I'll try on another system, or else just provide the patch for Brian (who requested the implicit approach) to work this out...
Thomas
Replacement patch for further analysis attached.
OK, this patch as attached to my previous mail apparently works, verified after rebuild:
0001-implicit-Unicode-data-tables-generation.patch

Thomas


---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]