Re: [PATCH] implicit Unicode data tables generation

[Thomas Wolff <towo at towo dot net>]

Am 08.03.2018 um 23:09 schrieb Thomas Wolff:
> Am 08.03.2018 um 09:07 schrieb Corinna Vinschen:
> > On Mar  8 00:27, Thomas Wolff wrote:
> > > This patch adds rules to generate Unicode data tables for
> > > libc/string/wcwidth, libc/ctype/tow* and libc/ctype/isw* implicitly,
> > > however, the build process is not yet covered.
> > > The rules define how the necessary data tables are built,
> > > but additional dependencies are missing to get the rules actually 
> > > invoked,
> > > like:
> > > (string/Makefile.am)
> > > wcwidth.c:    $(srcdir)/ambiguous.t $(srcdir)/combining.t 
> > > $(srcdir)/wide.t
> > > (ctype/Makefile.am)
> > > categories.c:   $(srcdir)/categories.t
> > > towctrans_l.c:  $(srcdir)/caseconv.t
> > > I tried some variations (like $(srcdir)/wcwidth.c:..., 
> > > lib_a-wcwidth.o:...,
> > > and even an additional dummy wcwidth.h) but it did not work;
> > Look at ctype/Makefile.am, last line:
> >
> > $(lpfx)ctype_.$(oext): ctype_.c ctype_iso.h ctype_cp.h
> >
> > This should work for this case here, too.
> Thanks, the following rules actually trigger the dependencies:
> (string)
> $(lpfx)wcwidth.$(oext): wcwidth.c ambiguous.t combining.t wide.t
> (ctype)
> $(lpfx)categories.$(oext): categories.c categories.t
> $(lpfx)towctrans_l.$(oext): towctrans_l.c caseconv.t
>
> but they cause obscure compilation errors:
> In file included from /usr/include/sys/config.h:234:0,
>                  from /usr/include/_ansi.h:11,
>                  from ../../../.././newlib/libc/string/wcwidth.c:91:
> /usr/include/cygwin/config.h:40:29: fatal error: ../tlsoffsets64.h: No 
> such file or directory
>  #include "../tlsoffsets64.h"
>                              ^
> (Maybe it's just one of these volatile errors that occasionally occur 
> when building cygwin?)
> I'll try on another system, or else just provide the patch for Brian 
> (who requested the implicit approach) to work this out...
> Thomas
Replacement patch for further analysis attached.

Attachment: 0001-implicit-Unicode-data-tables-generation.patch
Description: Text document