Re: [PATCH] _lseek missing return type

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb  9 09:40, Jaap de Wolff wrote:
> In syscalls _lseek was missing a return type
> 
> Jaap de Wolff
> 
> diff --git a/libgloss/arm/syscalls.c b/libgloss/arm/syscalls.c
> index 8163c7983..5548dcfb3 100644
> --- a/libgloss/arm/syscalls.c
> +++ b/libgloss/arm/syscalls.c
> @@ -493,6 +493,7 @@ _swilseek (int fd,
>      return -1;
>  }
>  
> +int
>  _lseek (int fd,
>  	int ptr,
>  	int dir)
> 

I'm somewhat aghast at this.  lseek is supposed to return off_t and
the ptr parameter should be off_t as well.  Shouldn't this be fixed
the right way?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature