This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]prevent warnings in libc/reent folder

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Fri, 9 Feb 2018 18:23:16 +0100
Subject: Re: [PATCH]prevent warnings in libc/reent folder
Authentication-results: sourceware.org; auth=none
References: <002401d3a0c8$abfcef60$03f6ce20$@jasoon.nl>
Reply-to: newlib at sourceware dot org

On Feb  8 11:36, Jaap de Wolff wrote:
> At this moment we get warnings while we compile the libc/reent folder.
> This patch will prevent this

Apart from the patch format, I'm not overly happy with adding all these
forward declararations to C files.  For instance, _fstat is already
declared in sys/stat.h and including this file should have precedence
over a local forward declaration.

Look at newlib/libc/include/sys/stat.h.  Check where the functions
are prototyped and include the matching header.  If functions are not
prototyped, add a prototype to the correct header.  The correct
header is the one where the base function (no trailing underscore)
is defined.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH]prevent warnings in libc/reent folder
  - From: Jaap de Wolff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]