This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [patches] [PATCH 1/2] RISC-V: Fix alignment issue in sigjmp_buf
- From: Palmer Dabbelt <palmer at sifive dot com>
- To: Jim Wilson <jimw at sifive dot com>
- Cc: Kito Cheng <kito dot cheng at gmail dot com>, newlib at sourceware dot org, patches at groups dot riscv dot org
- Date: Thu, 18 Jan 2018 12:56:11 -0800 (PST)
- Subject: Re: [patches] [PATCH 1/2] RISC-V: Fix alignment issue in sigjmp_buf
- Authentication-results: sourceware.org; auth=none
On Thu, 18 Jan 2018 11:42:56 PST (-0800), Jim Wilson wrote:
On 01/18/2018 10:58 AM, Palmer Dabbelt wrote:
On Wed, 17 Jan 2018 19:04:20 PST (-0800), Kito Cheng wrote:
This patch fix a potential mis-alignment issue in sigjump_buf, load a
double floating value required 8 bytes align, but we just align to
size of long, it's may cause mis-align memory access in rv32imafd.
This looks good to me. Do you want me to co-maintain the RISC-V newlib
port? IIRC you're the only maintainer, which can be a lot of work.
I already have write after approval access for newlib, and have been
reviewing pull requests in the github riscv-newlib project. This patch
was part of
https://github.com/riscv/riscv-newlib/pull/30/
I also checked in the last set of patches that Kito sent. If we need a
co-maintainer, it might make more sense for it to be me.
That works for me. Thanks for volunteering!
Jim
--
You received this message because you are subscribed to the Google Groups "RISC-V Patches" group.
To unsubscribe from this group and stop receiving emails from it, send an email to patches+unsubscribe@groups.riscv.org.
To post to this group, send email to patches@groups.riscv.org.
Visit this group at https://groups.google.com/a/groups.riscv.org/group/patches/.
To view this discussion on the web visit https://groups.google.com/a/groups.riscv.org/d/msgid/patches/ec81c771-7f98-1166-f714-3a0c7a4f6be0%40sifive.com.
For more options, visit https://groups.google.com/a/groups.riscv.org/d/optout.