Re: [PATCH v2 2/2] newlib/.../getreent.c: Allow to be provided by host and do so for RTEMS

[Corinna Vinschen <vinschen at redhat dot com>]

On Nov 10 12:06, Joel Sherrill wrote:
> On 10/13/2017 4:15 AM, Corinna Vinschen wrote:
> > I still need an explanation for _dummy_getreent.  It's kind of ugly.
> > Why exaclty is it required?
> 
> I modeled this on other files in libc/ including reent/,
> stdlib/ and time/. They have a "_dummy_XXX" variable. I vaguely
> recall something about this avoids having an object
> with no symbols in a library. Do "grep -r _dummy_ ." from
> the top of libc and you will see more than 20 examples.
> 
> They appear to be for a variety of conditionals like
> ABORT_PROVIDED, REENTRANT_SYSCALLS_PROVIDED, NO_EXEC,
> SIGNAL_PROVIDED, etc.

I never actively noticed this dummy var stuff.  I still think this is
really ugly.  What should have happened is that the source file is
simply not built in these cases, rather than to include a dummy var.
But it's apparently historic and given that this is common practice in
newlib, I pushed your patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature