Re: [PATCH v3 2/2] newlib/.../getreent.c: Do not define if __DYNAMIC_REENT__ is enabled

[Corinna Vinschen <vinschen at redhat dot com>]

On Nov  2 13:08, Sebastian Huber wrote:
> On 27/10/17 23:32, Joel Sherrill wrote:
> > [...]
> __getreent() is only used if __DYNAMIC_REENT__ is defined:
> 
> #if defined(__DYNAMIC_REENT__) && !defined(__SINGLE_THREAD__)
> #ifndef __getreent
>   struct _reent * _EXFUN(__getreent, (void));
> #endif
> # define _REENT (__getreent())
> #else /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */
> # define _REENT _impure_ptr
> #endif /* __SINGLE_THREAD__ || !__DYNAMIC_REENT__ */
> 
> Why can't we delete this file (newlib/libc/reent/getreent.c)?

It was meant as the default implementation I think.  There may
even have been a time where Cygwin needed it, but AFAICS, this
doesn't apply anymore.

So, yeah, we may try to remove it and see what breaks...


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature