Re: [PATCH v2] New expf, exp2f, logf, log2f and powf implementations

[Corinna Vinschen <vinschen at redhat dot com>]

On Oct 11 12:28, Jeff Johnston wrote:
> On Wed, Oct 11, 2017 at 8:05 AM, Corinna Vinschen <vinschen@redhat.com>
> wrote:
> 
> > On Sep 29 11:41, Szabolcs Nagy wrote:
> > > On 05/09/17 09:38, Corinna Vinschen wrote:
> > > > Ok, I retract my reservations against OBSOLETE_MATH as such.  However,
> > > > there are a few problems with the current patch:
> > > >
> > > > - Rename to __OBSOLETE_MATH (two underscores) so as not to spoil the
> > > >   namespace.
> > > >
> > > > - The current implementation disallows a developer to override the
> > > >   setting from, e. g., sys/config.h or the command line.  As a minimum,
> > > >   __OBSOLETE_MATH should only be set if it isn't already set, and the
> > > >   checks for __OBSOLETE_MATH should check for being != 0:
> > > >
> > > >   - #define __TGT_OBSOLETE_MATH 1 in arm and aarch cases
> > > >
> > > >   - At the end of the file
> > > >
> > > >     #ifndef __OBSOLETE_MATH
> > > >     #define __OBSOLETE_MATH __TGT_OBSOLETE_MATH
> > > >     #endif
> > > >
> > > >   - Further checks in the code:
> > > >
> > > >     #if __OBSOLETE_MATH
> > > >
> > > >     rather than
> > > >
> > > >     #ifdef __OBSOLETE_MATH
> > > >
> > > > - The header of ieeefp.h explains the options.  Add
> > __TGT_OBSOLETE_MATH /
> > > >   __OBSOLETE_MATH and add an informative comment along the lines of the
> > > >   above text, so developers have enough info to decide if they want to
> > > >   enable this for their target.
> > > >
> > > > Not sure if __TGT_OBSOLETE_MATH is a good name, though.  I'm open for
> > > > better suggestions.
> > > >
> > >
> > > i used __OBSOLETE_MATH_DEFAULT.
> > >
> > > v2:
> > > - Use __OBSOLETE_MATH and __OBSOLETE_MATH_DEFAULT.
> > > - Upstream change: whitespace code style fixes.
> > > - Upstream change: HIDDEN attribute for data symbols.
> > > - Upstream change: __logf_data.poly array size is reduced.
> > > - Upstream change: issignalingf_inline now has code for non-standard
> > SNaN.
> >
> > The above points have been fixed, so I'm ok with the change if
> > it makes sense from an FP point of view.  Jeff?
> >
> 
> I am fine with it.  Please go ahead.

You have push perms, too ;)

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature