Re: [PATCH] Modify strnstr.c.

[Corinna Vinschen <vinschen at redhat dot com>]

On Aug 28 23:14, Sichen Zhao wrote:
> > On 08/28/2017 03:45 AM, Corinna Vinschen wrote:
> > > On Aug 26 21:28, Sichen Zhao wrote:
> > > > ---
> > > >   newlib/libc/string/strnstr.c | 24 ++++++++----------------
> > > >   1 file changed, 8 insertions(+), 16 deletions(-)
> > > > 
> > > Input needed:
> > > 
> > > Given this is a complete reimplementation not based on FreeBSD code at
> > > all, and given the code has been contributed by Eric, shouldn't we
> > > remove the entire copyright header and move this under newlib default
> > > licensing?
> > Seems reasonable to me (we aren't really copying the FreeBSD
> > implementation, just the interface). Default newlib licensing is fine;
> > it's also okay if you list yourself as author instead of me (I didn't
> > test my code, only suggested it), although if you want to put authorship
> > on my shoulders that's also okay.
> > 
> Ok, the license of newlib. i copy it from other c file in newlib, like:
> /* Copyright 2017, Red Hat Inc. */
> Is that ok?

Just remove the FreeBSD copyright and don't add another one.  Files
without copyright default to newlib copyright anyway.

What would be pretty nifty, though: Can you add some man page entry,
along the lines of, say, libc/string/memmem.c?  This also requires a
tiny patch to libc/string/strings.tex.  This would not be a requirement
for what we're discussing here, just an idea for a followup patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature